Create SchemaVersion Tables with Partition Column #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
approved these changes
Jul 24, 2020
Contributor
alexshtin
left a comment
alexshtin
left a comment
There was a problem hiding this comment.
I don't quite understand the purpose but from code prospective it looks ok.
Contributor
Author
Clarified in person :) This is necessary to keep all records pinned to a single shard in case the tables need to be present in a sharded Vitess keyspace (they do currently). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
version_partitioncolumn to MySQL/Postgresschema_versionandschema_update_historytables.REPLACE INTOusage toINSERT ON DUPLICATE KEY UPDATEfor thewriteSchemaVersionQuery.Why?
We will need to change schema creation behavior in the future to support Vitess as we cannot perform schema structure CRUD operations over the mysql interface. However this ensures we have the correct key structure for the future.
How did you test it?
Existing CLI Schema Update Unit Tests